https://bugzilla.redhat.com/show_bug.cgi?id=1635340 --- Comment #2 from Marek Skalický <mskalick@xxxxxxxxxx> --- Thanks for the review. I've changed: - Group: and scriptlets are removed - fixed soname glob in %files - License: is updated and %license is used (also THIRD-PARTY-NOTICES file is installed as license) - removed unused code - added 'Conflicts: mongo-cxx-driver-devel' for -devel subpackage (both use same file location) Now I was trying to unbundle gtest, but mongo-cxx-driver-legacy don't compile with this change. Upstream doen't support unbundling, gtest is test only dependency and other bundled libs are really small and aren't packaged in Fedora). So in this case IMHO bundling isn't big problem. Also I've realized that newer version is available - 1.1.3 (instead of 1.1.2). So rebase to this version was done. Spec URL: https://mskalick.fedorapeople.org/reviews/mongo-cxx-driver-legacy/mongo-cxx-driver-legacy.spec SRPM URL: https://mskalick.fedorapeople.org/reviews/mongo-cxx-driver-legacy/mongo-cxx-driver-legacy-1.1.3-1.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
