[Bug 1634014] Review Request: python-grpcio - A high performance, open-source universal RPC framework

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1634014



--- Comment #3 from Mathieu Bridon <bochecha@xxxxxxxxxxx> ---
New package:

Spec URL: https://bochecha.fedorapeople.org/packages/python-grpcio.spec
SRPM URL:
https://bochecha.fedorapeople.org/packages/python-grpcio-1.15.0-2.fc28.src.rpm

All your points should now be fixed:

diff --git a/python-grpcio.spec b/python-grpcio.spec
index 3b6bc7a..d54d596 100644
--- a/python-grpcio.spec
+++ b/python-grpcio.spec
@@ -6,7 +6,7 @@ License:       ASL 2.0
 URL:           https://pypi.org/project/%{srcname}

 Version:       1.15.0
-Release:       1%{?dist}
+Release:       2%{?dist}
 Source0:       %pypi_source

 BuildRequires: gcc
@@ -18,10 +18,9 @@ BuildRequires: python3-devel >= 3.4
 BuildRequires: zlib-devel

 BuildRequires: python3-Cython
+BuildRequires: python3-setuptools
 BuildRequires: python3-six >= 1.5.2

-Requires:      python3-six >= 1.5.2
-
 %description
 A high performance, open-source universal RPC framework.

@@ -30,6 +29,7 @@ This package allows using gRPC in Python applications.

 %package -n python3-%{srcname}
 Summary:       %{summary}
+Requires:      python3-six >= 1.5.2
 %{?python_provide:%python_provide python3-%{srcname}}

 %description -n python3-%{srcname}
@@ -64,11 +64,16 @@ export GRPC_PYTHON_LDFLAGS="%{build_ldflags}"

 %files -n python3-%{srcname}
 %doc README.md
-%{python3_sitearch}/grpc
-%{python3_sitearch}/grpcio-%{version}-py*.egg-info
+%{python3_sitearch}/grpc/
+%{python3_sitearch}/grpcio-%{version}-py*.egg-info/


 %changelog
+* Fri Sep 28 2018 Mathieu Bridon <bochecha@xxxxxxxxxxx> - 1.15.0-2
+- Added missing build requirement on python3-setuptools.
+- Moved a requirement to the right subpackage.
+- Added trailing slashes to installed directories.
+
 * Fri Sep 28 2018 Mathieu Bridon <bochecha@xxxxxxxxxxx> - 1.15.0-1
 - Update to the latest upstream release.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux