https://bugzilla.redhat.com/show_bug.cgi?id=1633741 --- Comment #3 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - Not needed: %{!?python_sitearch: %global python_sitearch %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib(1)")} - Group: is not used in Fedora - Add a comment explaining why the patch are needed or link to an upstream bug report/PR - Use /usr/bin/python2, not /usr/bin/python, which is deprecated: export PYTHON=%{__python2} - make → %make_build (unless parallel compilation is broken) - Not needed: rm -rf $RPM_BUILD_ROOT - make DESTDIR=$RPM_BUILD_ROOT install → %make_install - Use of %{python_sitearch} is forbidden, use %{python2_sitearch} rm $RPM_BUILD_ROOT/%{python2_sitearch}/gtk-2.0/%{pypkgname}/_%{pypkgname}.la - License file COPYING must be installed with %license, not %doc: %files -n python2-notify %license COPYING %doc AUTHORS NEWS ChangeLog -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
