https://bugzilla.redhat.com/show_bug.cgi?id=1632439 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- > URL and Source0 are ok > TODO: Is there any special reason why you use url > https://github.com/marcusramberg/Mojolicious-Plugin-OAuth2 > instead of metacpan.org as most of Perl packages? > Please consider the changing to > Source0: https://metacpan.org/release/Mojolicious-Plugin-OAuth2 > URL: > https://cpan.metacpan.org/authors/id/M/MR/MRAMBERG/Mojolicious-Plugin-OAuth2- > %{version}.tar.gz -URL: https://github.com/marcusramberg/Mojolicious-Plugin-OAuth2 -Source0: https://github.com/marcusramberg/Mojolicious-Plugin-OAuth2/archive/%{version}/Mojolicious-Plugin-OAuth2-%{version}.tar.gz +URL: https://metacpan.org/release/Mojolicious-Plugin-OAuth2 +Source0: https://cpan.metacpan.org/authors/id/M/MR/MRAMBERG/Mojolicious-Plugin-OAuth2-%{version}.tar.gz Fixed > BuildRequires > FIX: Please add build-requires > - %{__make} > - perl(Carp) - lib/Mojolicious/Plugin/OAuth2.pm:6 > - perl(File::Find) - t/00-basic.t:2 > - perl(Mojo::Promise) - lib/Mojolicious/Plugin/OAuth2.pm:4 > - perl(Mojo::UserAgent) - lib/Mojolicious/Plugin/OAuth2.pm:5 > - perl(Mojolicious::Plugin) - lib/Mojolicious/Plugin/OAuth2.pm:2 +BuildRequires: perl(Carp) +BuildRequires: perl(File::Find) +BuildRequires: perl(Mojo::Promise) +BuildRequires: perl(Mojo::UserAgent) +BuildRequires: perl(Mojolicious::Plugin) Fixed > FIX: Please remove build-requires perl(Scalar::Util) and perl(Test::Output). > I did not find any using of them. -BuildRequires: perl(Scalar::Util) -BuildRequires: perl(Test::Output) >= 1 Fixed > FIX: Please add run requires > - perl(Mojolicious::Plugin) - lib/Mojolicious/Plugin/OAuth2.pm:2 +Requires: perl(Mojolicious::Plugin) Fixed The package look good now. Approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
