[Bug 1607271] Review Request: perl-HTML-Tidy5 - HTML validation in a Perl object

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1607271



--- Comment #4 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
You didn't solve the other point I mentioned:


 - NO_PACKLIST=1 is only supported on perl(ExtUtils::MakeMaker) >= 6.76, thus
you should constrain your BR:

BuildRequires:  perl(ExtUtils::MakeMaker) >= 6.76

 - PERL_INSTALL_ROOT is not used anymore, it is replaced by DESTDIR:

%{__make} pure_install DESTDIR=$RPM_BUILD_ROOT

 - You need add perl-interpreter at a BR:

perl-interpreter – The Perl interpreter must be listed as a build dependency if
it is called in any way, either explicitly via perl or %__perl, or as part of
your package's build system.

BuildRequires:  perl-interpreter



You should discuss with Corsepius whether he agrees or not to leave you this
package. Also you're not a member of the packager group so you would also need 
a sponsor.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux