https://bugzilla.redhat.com/show_bug.cgi?id=1583798 --- Comment #6 from Rex Dieter <rdieter@xxxxxxxxx> --- $ rpmlint *.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. naming: ok licensing: ok but consider adding a comment near the License: tag as reference to which licenses apply to which parts of the software sources: ok $ md5sum *.xz ac7581529766edb8f8c89f4515c94a15 termysequence-qt-1.1.0.tar.xz 1. similar to termy-sever review, SHOULD remove # Build type "None" disables Release/Debug CFLAGS and LDFLAGS set by CMake. # Only the CFLAGS and LDFLAGS specified by rpmbuild will be used. and consider using -DCMAKE_BUILD_TYPE=Release instead. scriptlets: n/a macros: ok 2. since this bundles a copy of v8, MUST add something like: Provides: bundled(v8) = <version> per https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Libraries#Requirement_if_you_bundle -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
