https://bugzilla.redhat.com/show_bug.cgi?id=1628148 --- Comment #4 from Lubomir Rintel <lkundrak@xxxxx> --- Thanks for the review. (In reply to Robert-André Mauchin from comment #1) > - Group: is not used in Fedora Dropped. > - make %{?_smp_mflags} → %make_build > > - Tell upstream to fix the FSF adress in: > > psftools.x86_64: E: incorrect-fsf-address > /usr/share/licenses/psftools/COPYING Done (In reply to Lubomir Rintel from comment #2) > (In reply to Robert-André Mauchin from comment #1) > > - make %{?_smp_mflags} → %make_build > > Why? (In reply to Robert-André Mauchin from comment #3) > That's not mandatory, it's for consistency sake. I'm leaving it as it is. Most packages I've seen use the former one, and thus it's perhaps the more consistent form. Also, the packaging guidelines seem to use that form in examples, and so does Vim's SPEC file template. Updated version: SPEC: http://v3.sk/~lkundrak/SPECS/psftools.spec SRPM: http://v3.sk/~lkundrak/SRPMS/psftools-1.0.10-2.fc28.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
