https://bugzilla.redhat.com/show_bug.cgi?id=1627510 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - %setup -q %autopatch Simply use %autosetup - Add a comment explaining what the patch does or why it is needed - export CFLAGS=-g export LDFLAGS=-g Use %set_build_flags - make %{?_smp_mflags} → %make_build - %{__make} install DESTDIR=%{buildroot} → %make_install - %post /sbin/ldconfig %postun /sbin/ldconfig This is not necessary anymore as it has been automated with %transfiletrigger tarting F28. If you intend to support F27, add %ldconfig_scriptlets - Licenses files must be installed with %license, not %doc: %files %license COPYING COPYING.bsd COPYING.gplv2 %doc README.md - License field is incorrect, it should be: License: BSD or GPLv2 - You should use %{?_isa} here: Requires: %{name}%{?_isa} = %{version}-%{release} - It would be nice to patch the Makefile to use $(INSTALL) instead of install: sed -i "s|^\tinstall -|\t\$(INSTALL) -|" Makefile in order to keep the timestamps. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
