[Bug 1503915] Review Request: roca-detect - test RSA public keys for ROCA vulnerability

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1503915



--- Comment #34 from Miro Hrončok <mhroncok@xxxxxxxxxx> ---
I really don't get this conditional now:

%if 0%{?rhel} >= 7
Requires:    python-dateutil
%else
Requires:    %{python}-dateutil
%endif

What is it that you are trying to express? On RHEL7+, require python-dateutil,
but on RHEL6, require python3-dateutil? Why?

--------------

Requires:    %{python}-future %{python}-cryptography %{python}-pgpdump
# Not required in normal usage, but recommended by upstream.
Requires:    python3dist(six)

This mixes 2 types of specifying Python dependencies. As well as this doesn't
work with your python macros specified on top. Also, submit a pull request to
upstream if the six dependency is bogus.

I recommend you switch to
https://fedoraproject.org/wiki/Packaging:Python#Automatically_generated_dependencies

--------------

# fix env shbang in CLI scripts
sed -i -e '1,1 s,^#!.*$,#!%{__python} %{py_shbang_opts},' \
   `find roca -name "*.py" | xargs grep -l '^#!.*env python'`


You might very well just use pathfix.py as a one-liner.
https://fedoraproject.org/wiki/Changes/Make_ambiguous_python_shebangs_error#Using_pathfix.py_to_fix_shebangs

--------------

find . -name .gitignore | xargs rm

Why not just -delete?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux