[Bug 1503915] Review Request: roca-detect - test RSA public keys for ROCA vulnerability

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1503915



--- Comment #25 from Stuart D Gathman <stuart@xxxxxxxxxxx> ---
For  posterity, here is how the "EASY" entry point breaks:

roca-detect-tls
Traceback (most recent call last):
  File "/usr/bin/roca-detect-tls", line 11, in <module>
    load_entry_point('roca-detect==1.2.1', 'console_scripts',
'roca-detect-tls')()
  File "/usr/lib/python3.6/site-packages/pkg_resources/__init__.py", line 476,
in load_entry_point
    return get_distribution(dist).load_entry_point(group, name)
  File "/usr/lib/python3.6/site-packages/pkg_resources/__init__.py", line 2700,
in load_entry_point
    return ep.load()
  File "/usr/lib/python3.6/site-packages/pkg_resources/__init__.py", line 2318,
in load
    return self.resolve()
  File "/usr/lib/python3.6/site-packages/pkg_resources/__init__.py", line 2324,
in resolve
    module = __import__(self.module_name, fromlist=['__name__'], level=0)
  File "/usr/lib/python3.6/site-packages/roca/detect_tls.py", line 23, in
<module>
    from detect import RocaFingerprinter, logger, LOG_FORMAT
ModuleNotFoundError: No module named 'detect'


The problem is that the actual CLI scripts expect to be run directly, and when
loaded as a module by EASY, relative imports break.  If I patch the import,
then that breaks running the entry script directly.  Some sort of conditional
logic is needed on the imports for the EASY introducer to work correctly.  It
is insane to debug and workround the EASY bugs - when a symlink accomplishes
the intended result on Fedora systems.  

I am making the symlinks a conditional build option for building with and
without EASY.  Since EASY is broken as is, I am making the symlinks the
default.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux