[Bug 1625411] Review Request: perl-Dancer2-Plugin-Database - Easy database connections for Dancer2 applications

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1625411

Robert-André Mauchin <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
                 CC|                            |zebob.m@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |zebob.m@xxxxxxxxx
              Flags|                            |fedora-review+



--- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
URL and Source addresses are Ok.
Source archive (SHA-256:
431f3405413366d2f36ebe0fd4661cc6d3c1354ba46018484799c0757dc638bd) is original.
Ok.
Summary verified from lib/Dancer2/Plugin/Database.pm. Ok.
Description verified from lib/Dancer2/Plugin/Database.pm. Ok.
License verified from lib/Dancer2/Plugin/Database.pm and README. Ok.
No XS code, noarch BuildArch is Ok.

All tests pass. Ok.


 -Build fails:

Erreur de construction de RPM :
BUILDSTDERR: erreur : Fichier(s) installé(s) (mais non empaquetés) :
BUILDSTDERR:   
/usr/lib64/perl5/vendor_perl/auto/Dancer2/Plugin/Database/.packlist
BUILDSTDERR:     Fichier(s) installé(s) (mais non empaquetés) :
BUILDSTDERR:   
/usr/lib64/perl5/vendor_perl/auto/Dancer2/Plugin/Database/.packlist
Child return code was: 1

   Use:

perl Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1


$ rpmlint perl-Dancer2-Plugin-Database.spec
review-perl-Dancer2-Plugin-Database/results/perl-Dancer2-Plugin-Database-2.17-1.fc30.noarch.rpm
review-perl-Dancer2-Plugin-Database/results/perl-Dancer2-Plugin-Database-2.17-1.fc30.src.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.


$ rpm -q -lv -p perl-Dancer2-Plugin-Database-2.17-1.fc30.noarch.rpm            
                           18:51:42
drwxr-xr-x    2 root    root                        0 sept.  5 18:46
/usr/share/doc/perl-Dancer2-Plugin-Database
-rw-r--r--    1 root    root                     1952 août 13  2016
/usr/share/doc/perl-Dancer2-Plugin-Database/Changes
-rw-r--r--    1 root    root                    13724 août  5  2016
/usr/share/doc/perl-Dancer2-Plugin-Database/README
-rw-r--r--    1 root    root                     6433 sept.  5 18:46
/usr/share/man/man3/Dancer2::Plugin::Database.3pm.gz
drwxr-xr-x    2 root    root                        0 sept.  5 18:46
/usr/share/perl5/vendor_perl/Dancer2
drwxr-xr-x    2 root    root                        0 sept.  5 18:46
/usr/share/perl5/vendor_perl/Dancer2/Plugin
-rw-r--r--    1 root    root                    14516 août 13  2016
/usr/share/perl5/vendor_perl/Dancer2/Plugin/Database.pm
File permissions and layout are Ok.

$ rpm -q --requires -p perl-Dancer2-Plugin-Database-2.17-1.fc30.noarch.rpm |
sort -f | uniq -c             18:52:44
      1 perl(:MODULE_COMPAT_5.28.0)
      1 perl(Dancer2::Plugin)
      1 perl(Dancer::Plugin::Database::Core)
      1 perl(Dancer::Plugin::Database::Core::Handle)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p perl-Dancer2-Plugin-Database-2.17-1.fc30.noarch.rpm     
                           18:55:02
perl(Dancer2::Plugin::Database) = 2.17
perl-Dancer2-Plugin-Database = 2.17-1.fc30
Binary provides are Ok.


Package builds in mock F30.
Ok

The package is in line with Fedora and Perl packaging guidelines.

Resolution: Package approved. Please fix the aforementioned issue before
import.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux