[Bug 1503915] Review Request: roca-detect - test RSA public keys for ROCA vulnerability

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1503915



--- Comment #14 from Miro Hrončok <mhroncok@xxxxxxxxxx> ---
3,4.

    %py_build    # Fails with "fg: no job control"
    #{__python} setup.py build

Please just keep the %py_build macro. (Same for install.)


1. This still stands


6. There is more markdown in %description, plese use plaintext.


9. I don't agree, but apparently there is nothing I can do to stop you. At
least, please make the script PEP8 compliant and set the shebang line to:

    #!%{__python} %{py_shbang_opts}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux