https://bugzilla.redhat.com/show_bug.cgi?id=1624208 --- Comment #3 from "FeRD" (Frank Dana) <ferdnyc@xxxxxxxxx> --- Thanks very much, Robert-André. I appreciate you taking the time to review, and for and the helpful pointers. I've updated the package in accordance with your feedback. (In reply to Robert-André Mauchin from comment #2) > - Not needed: > - Not used anymore: > - subpackage -devel should require -libs, not the main package: > - To avoid unintended soname bump, it is now forbidden to use a glob for > the major soname version, be more precise instead > - You need to Requires: hicolor-icon-theme to own the icons > directories > - Add gcc as a BR All completed. > - The license field should also mention CC-BY-SA and add a comment > explaining the license breakdown. Also install COPYING_CCBYSA with %license > in %files. Done, COPYING_CCBYSA is packaged via %license and the spec now reads: # Source code is licensed GPLv3+, icons and help files are CC-BY-SA License: GPLv3+ and CC-BY-SA I wanted to ask: COPYING_CCBYSA applies two different versions of the CC license, for some reason. * the icon files are licensed Creative Commons Attribution-Share Alike 3.0 * the help content is licensed Creative Commons Attribution-ShareAlike 4.0 Do I need to get into that level of detail in the License: line, or does "CC-BY-SA" sufficiently cover it? Updated Spec: https://copr-be.cloud.fedoraproject.org/results/ferdnyc/parlatype/srpm-builds/00794202/parlatype.spec Updated SRPM: https://copr-be.cloud.fedoraproject.org/results/ferdnyc/parlatype/srpm-builds/00794202/parlatype-1.5.6-1.fc28.src.rpm Specfile diff in dist-git: https://copr-dist-git.fedorainfracloud.org/cgit/ferdnyc/parlatype/parlatype.git/diff/?id=40002f3b18d0be63bd97c883ba76b4c493738b7e Modulo, possibly, that last question of licensing detail, I believe those should address all of the necessary changes. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
