[Bug 1624921] Review Request: mozjs60

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1624921



--- Comment #7 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
ARM: There's an issue with --disable-ion and ARM, it leads to the inclusion of
both js/src/jit/arm/Architecture-arm.h and js/src/jit/none/Architecture-none.h
because --disable-ion requires arch none and js/src/jit/AtomicOperations.h
forces the inclusion of js/src/jit/arm/AtomicOperations-arm.h which itself
#include js/src/jit/arm/Architecture-arm.h

In both mozjs45
(https://src.fedoraproject.org/rpms/mozjs45/blob/73b5a5b1cf41c76beb9906b30376ab35092be292/f/fix-atomicoperatios.patch)
and mozjs52
(https://src.fedoraproject.org/rpms/mozjs52/blob/f893fb022139ece17f36955a068f4141cdcc9b4d/f/mozilla-1253216.patch),
this was solved by patching js/src/jit/AtomicOperations.h to use
js/src/jit/none/AtomicOperations-ppc.h instead of
js/src/jit/arm/AtomicOperations-arm.h but this file does not exist anymore as
it has been replaced by js/src/jit/none/AtomicOperations-feeling-lucky.h with
lots of changes.


There's the question of why do we need to disable ion for theses arches, back
in firefox 45 there were js build failures for the new GCC 6 (
https://bugzilla.mozilla.org/show_bug.cgi?id=1253216 ), is it still needed now?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux