https://bugzilla.redhat.com/show_bug.cgi?id=1582983 Rex Dieter <rdieter@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841 (FE-NEEDSPONSOR) | Flags|fedora-review? |fedora-review+ --- Comment #15 from Rex Dieter <rdieter@xxxxxxxxx> --- Thanks for the update, and apologies for my tardiness. Found some free time today finally. built/installed ok locally, $ sudo rpmlint termy-server 1 packages and 0 specfiles checked; 0 errors, 0 warnings. naming: ok sources: ok $ md5sum *.xz e8fdf6191c01d1eab2d0b968e42161f3 termysequence-server-1.1.0.tar.xz licensing: ok scriptlets: ok 1. SHOULD remove: # Build type "None" disables Release/Debug CFLAGS and LDFLAGS set by CMake. # Only the CFLAGS and LDFLAGS specified by rpmbuild will be used. ...# Build type "None" disables Release/Debug CFLAGS and LDFLAGS set by CMake. # Only the CFLAGS and LDFLAGS specified by rpmbuild will be used. # -DCMAKE_BUILD_TYPE=None \ -DCMAKE_BUILD_TYPE=None \ This does not appear to be true. and if it was, fixing or workaround here is the wrong place to do it (cmake and it's macros should be fixed instead). Please remove this. Otherwise, fairly simple and clean. APPROVED. I'll sponsor you shortly. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
