[Bug 1613036] Review Request: oshinko-cli - Command line interface for spark cluster management app

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1613036



--- Comment #15 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
 - I would switch 0%{?rhel} >= 7 to == 7, I hope for RHEL 8 we will have our
new Go packaging working.

 - Use a more meaningful name for your archive:

Source0:        %url/archive/v%{version}/%{name}-%{version}.tar.gz

 - Split the description to stay below 80 characters per line:


oshinko-cli.x86_64: W: spelling-error %description -l en_US subdirectory -> sub
directory, sub-directory, directory
oshinko-cli.x86_64: E: description-line-too-long C The oshinko application
manages Apache Spark clusters on OpenShift. The application
oshinko-cli.x86_64: E: description-line-too-long C consists of a REST server
(oshinko-rest) and a web UI and is designed to run in an
oshinko-cli.x86_64: E: description-line-too-long C This repository contains
tools to launch the oshinko application along with the source
oshinko-cli.x86_64: E: description-line-too-long C code for the oshinko REST
server in the rest subdirectory. The source code for the web


 - Changelog entry is incorrect

oshinko-cli.x86_64: W: incoherent-version-in-changelog 0-0.5.4 ['0.5.4-0.fc30',
'0.5.4-0']

   It should be

* Thu Jul 26 2018 Ricardo Martinelli de Oliveira <rmartine@xxxxxxxxxx> -
0.5.4-1

 - And Release should start at 1

Release:        1%{?dist}


 - Use %global not define:

%global debug_package %{nil}

Also only use it on EPEL since it's where it fails

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux