https://bugzilla.redhat.com/show_bug.cgi?id=1623220 --- Comment #3 from Stephen Gallagher <sgallagh@xxxxxxxxxx> --- (In reply to Petr Šabata from comment #2) > * I don't see the need for that runtime dependency on setuptools. > What's the point? That was added automatically by pyp2rpm; it's probably not needed. > > * Missing runtime dependency on python3-gobject-base or equivalent. Ah, right. Good catch. > > * All files state "Copyright (C) 2017-2018 Stephen Gallagher", yet the > first upstream commit is from a week ago. Oops, copy-paste error. > > * Does cli.py need the shebang line? It does not need one, it's not meant to be directly executable. It's wrapped by console_scripts in setup.py. > > * As an executable, mmdzanata could have a manpage. It probably should, but I haven't written one yet and this isn't a blocker for initial review IMHO. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
