[Bug 1592220] Review Request: speech-tools - the current version of the support library for Festival

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1592220

Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #22 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
Stuff to fix after import:
> BuildRequires:  gcc-c++ ncurses-devel alsa-lib-devel
Those should be on separate lines. Otherwise diffs are hard to read.

> # Because of the copr build a https reachable mirror was needed
> Source0: https://trycht.cz/festvox/packed/festival/%{version}/speech_tools-%{version}.0-release.tar.gz
Please switch back to official URL.

> Source1: LICENSE
I see that the LICENSE file is not part of the upstream tarball. A real URL
would be better. Also, a link to an upstream issue about including the license
file would be great

> %description
Please wrap that paragraph to ~80 lines.

OK, package is (re-)APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux