https://bugzilla.redhat.com/show_bug.cgi?id=1613036 --- Comment #8 from Ricardo Martinelli de Oliveira <rmartine@xxxxxxxxxx> --- (In reply to Robert-André Mauchin from comment #6) > - I'd rather you do the opposite as I said: > > %global GIT_COMMIT 7acbd8382 > %global TAG %{VERSION}-%{GIT_COMMIT} > %global SPARK_IMAGE "radanalyticsio/openshift-spark:2.3-latest" > > export LDFLAGS="$LDFLAGS -X %{goipath}/version.gitTag=%{TAG} -X > %{goipath}/version.appName=oshinko -X > %{goipath}/version.sparkImage=%{SPARK_IMAGE}" > > %gobuild -o _bin/oshinko %{goipath}/cmd/oshinko > ln -s _bin/oshinko _bin/oshinko-cli > > %install > %goinstall > install -Dpm 0755 _bin/oshinko %{buildroot}%{_bindir}/oshinko > install -Dpm 0755 _bin/oshinko-cli %{buildroot}%{_bindir}/oshinko-cli > > > And drop the patch. > > - This shouldn't be needed: > > %global debug_package %{nil} For some reason, if I remove this line the epel-7 build fails. I can share my copr build with the error if you want > > %global gopath %{_datadir}/gocode > > - Use: > > URL: %{gourl} > Source0: %{gosource} The Source0 must be set as I did because the source generated by the go macro is wrong. But gourl macro is being used now. > > - I don't understand why you expect go_arches not to be defined, this whole > part should be removed, it is defined by %gometa: > > # If go_arches not defined fall through to implicit golang archs > %if 0%{?go_arches:1} > ExclusiveArch: %{go_arches} > %else > ExclusiveArch: x86_64 aarch64 ppc64le s390x > %endif As this package is to use with OpenShift, I just reused these lines from the OpenShift packages. > > If you plan for EPEL, the new Go packaging doesn't work there yet so you > would need to redo the SPEC in the old style anyway. I added some conditionals to run the go macros only for Fedora builds. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
