[Bug 1622347] Review Request: libwpe - a renaming of wpewebkit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1622347

Robert-André Mauchin <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zebob.m@xxxxxxxxx



--- Comment #2 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
If a package is being renamed without any functional changes, or is a
compatible enough replacement to an existing package (where "enough" means that
it includes only changes of magnitude that are commonly found in version
upgrade changes), provide clean upgrade paths and compatibility with:

Provides: oldpackagename = $provEVR
Obsoletes: oldpackagename < $obsEVR

$provEVR refers to an (Epoch-)Version-Release tuple the original unchanged
package would have had if it had been version or release bumped. You usually
use macros here because the provides EVR should continue to go up as the
renamed package advances in version and release. $obsEVR is an
(Epoch-)Version-Release tuple arranged so that there is a clean upgrade path
but without gratuitously polluting the version space upwards. You usually do
not use macros for this as you're simply trying to advance beyond the last
known release under the old name.

Per this guidelines, it should be:

Provides: wpebackend = %{version}-%{release} 
Obsoletes: wpebackend < 0.2.0-2


 - Source0 is 404. It should be:

Source0:       
https://github.com/WebPlatformForEmbedded/libwpe/releases/download/%{version}/%{name}-%{version}.tar.xz

 - Split the description to stay below 80 characters per line. Shorten the
summary and remove the dot at the end

libwpe.x86_64: W: summary-ended-with-dot C General-purpose library specifically
developed for the WPE-flavored port of WebKit.
libwpe.x86_64: E: summary-too-long C General-purpose library specifically
developed for the WPE-flavored port of WebKit.
libwpe.x86_64: E: description-line-too-long C General-purpose library
specifically developed for the WPE-flavored port of WebKit.

 - The %changelog Version-Release entry is not correct:

* Fri Jul 13 2018 Chris King <bunnyapocalypse@xxxxxxxxxxxxxxxxx> - 1.0.0-1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux