https://bugzilla.redhat.com/show_bug.cgi?id=1615640 Jaroslav Škarvada <jskarvad@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jskarvad@xxxxxxxxxx --- Comment #4 from Jaroslav Škarvada <jskarvad@xxxxxxxxxx> --- Some issues found: - you should use desktop-file-install or desktop-file-validate to install *.desktop file (https://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage) - you shouldn't install classification-banner-screenshot.png into /usr/share. Install it under e.g. /usr/share/doc/%{name} or /usr/share/%{name} - I think it should be licensed under GPLv2+, not GPLv2, see the license text: "... If the Program does not specify a version number of this License, you may choose any version ever published by the Free Software Foundation..." and it doesn't seem the program or web page specifies exact version. Please fix these issues before fedora push. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
