Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: outerspace - client for 4x on-line strategy game https://bugzilla.redhat.com/show_bug.cgi?id=253781 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-09-13 10:45 EST ------- Well, much progress!! For 0.2.2-1: * Redundant Requires - "Requires: python >= 2.3" is not needed. rpmbuild automatically checks python version dependency for this package. You can see "rpm -q --requires outerspace" contains "python(abi) = 2.5". * Desktop file vendor -------------------------------------------- desktop-file-install \ --vendor="ospace.net" \ -------------------------------------------- - Please change the vendor name to "fedora". * %files entry cleanup - When foo is a directory, writing -------------------------------------------- %files foo/ -------------------------------------------- means the directory foo/ itself and all the files/directories/etc under foo/. So: -------------------------------------------- %dir %{python_sitelib}/oslauncher %{python_sitelib}/oslauncher/*.py* %dir %{python_sitelib}/oslauncher/pgu %{python_sitelib}/oslauncher/pgu/*.py* %dir %{python_sitelib}/oslauncher/pgu/gui %{python_sitelib}/oslauncher/pgu/gui/*.py* %dir %{python_sitelib}/oslauncher/urlgrabber %{python_sitelib}/oslauncher/urlgrabber/*.py* --------------------------------------------- can be replaced with one line: --------------------------------------------- %{python_sitelib}/oslauncher/ --------------------------------------------- * Directory ownership issue - Currently /usr/share/outerspace is not owned by any package. --------------------------------------------- %{_datadir}/%{name}/* --------------------------------------------- must be: --------------------------------------------- %{_datadir}/%{name}/ --------------------------------------------- * Duplicate file - The file "/usr/share/outerspace/gray/Vera.ttf" (in this package) is actually the same as "/usr/share/fonts/bitstream-vera/Vera.ttf", which is in bitstream-vera-fonts. So, please: - Replace /usr/share/outerspace/gray/Vera.ttf with the symlink to "../../fonts/bitstream-vera/Vera.ttf" (symlink should be relative) - And add "BuildRequires: bitstream-vera-fonts" "Requires: bitstream-vera-fonts". Then: ------------------------------------------------------------- NOTE: Before being sponsored: This package will be accepted with another few work. But before I accept this package, someone (I am a candidate) must sponsor you. Once you are sponsored, you have the right to review other submitters' review requests and approve the packages formally. For this reason, the person who want to be sponsored (like you) are required to "show that you have an understanding of the process and of the packaging guidelines" as is described on : http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored Usually there are two ways to show this. A. submit other review requests with enough quality. B. Do a "pre-review" of other person's review request (at the time you are not sponsored, you cannot do a formal review) When you have submitted a new review request or have pre-reviewed other person's review request, please write the bug number on this bug report so that I can check your comments or review request. Fedora package collection review requests which are waiting for someone to review can be checked on: http://fedoraproject.org/PackageReviewStatus/NEW.html (NOTE: please don't choose "Merge Review") Review guidelines are described mainly on: http://fedoraproject.org/wiki/Packaging/ReviewGuidelines http://fedoraproject.org/wiki/Packaging/Guidelines http://fedoraproject.org/wiki/Packaging/ScriptletSnippets ------------------------------------------------------------ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review