https://bugzilla.redhat.com/show_bug.cgi?id=1619528 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zbyszek@xxxxxxxxx --- Comment #15 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- (In reply to Lukáš Tyrychtr from comment #3) > - All build dependencies are listed in BuildRequires, except for any that > are listed in the exceptions section of Packaging Guidelines. > Note: These BR are not needed: make > See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 That's fedora-review being plain wrong. See https://bugzilla.redhat.com/show_bug.cgi?id=1613069, https://pagure.io/packaging-committee/issue/497#comment-146293. > [?]: Package does not own files or directories owned by other packages. > Note: Dirs in package are owned also by: /usr/lib64/mozilla/native- > messaging-hosts(webextension-token-signing, chrome-gnome-shell) The rule to not co-own directories is mostly outdated too. If there's a "-filesystem" package that owns those directories, then it's better to depend on it, but when there isn't, it's better for unrelated packages to co-own a directory than to introduce unwanted Requires. (In this case depending on mozilla-filesystem is fine, my comment was about the general case.) > License: GPLv3 The license is tagged wrong. Looking at the SPDX identifiers in https://github.com/jlebon/textern/blob/master/native/textern.py and other places shows that the license is GPLv3+. Unfortunately the GPLv3 LICENSE text is very long and one cannot tell if the program is license GPLv3 or GPLv3-or-later just by looking at the LICENSE file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/3APNFESNGQJER2WV67RT2EECCIA3HGYZ/
