Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lohit-fonts - font package for indic fonts https://bugzilla.redhat.com/show_bug.cgi?id=285591 petersen@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |petersen@xxxxxxxxxx Flag| |fedora-review? ------- Additional Comments From petersen@xxxxxxxxxx 2007-09-13 07:23 EST ------- Thanks for the update. Please bump the release number for each new revision. The rpmlint output is clean now. :) Presumably for Indic we don't need fonts.dir and fonts.scale? How about a catalogue file? (http://fedoraproject.org/wiki/Releases/FeatureNoMoreXFS) My review follows: Good: + rpmlint clean + package follows upstream project name + package is based on fonts-indic + following Packaging Guidelines except as noted below + license is good (GPLv2) and included + spec file is clearly written + md5sum is pristine bb9497ee772062b97ff00a1a68b17c98 fonts-indic-2.1.5.tar.gz + builds correctly + filelists are correct + font install scriptlets are standard Bad: - should not Requires fontconfig explicitly -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review