https://bugzilla.redhat.com/show_bug.cgi?id=1615816 José Matos <jamatos@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |jamatos@xxxxxxxx --- Comment #5 from José Matos <jamatos@xxxxxxxx> --- (In reply to Iñaki Ucar from comment #4) > You're right, thanks. I've removed R-core and udunits2 from Requires in the > SPEC and updated the SRPM accordingly (same links above). The procedure in this case is to bump the release number, add a new changelog indicating the changes and display again the location for the url and srpm. The advantage of this procedure is that it is always explicit to the possible different reviewers what the version being discussed. While with the online change the version that I have depends on the time I took it. And yes that has already happened to me (both as the proponent doing the changes in place and as a reviewer having the wrong version). The small inconvenience for you pays off for all, believe me. :-) If you increase the release number I will formally review and approve the package. :-) > Rcpp is needed > though, because 'importFrom(Rcpp,evalCpp)' is in the NAMESPACE. I spent time cheking why Rcpp the lib is not automatically linked into R-units and it seems that only the headers are used so you are right. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/IT7K6MLWND5FXQ4MQT347GY6W53M7LVK/
