[Bug 1614550] Review Request: liquid-dsp - Digital signal processing library for software-defined radios

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1614550



--- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
 - Same issue as before, why do you package a snapshot instead of the release

 - Also the latest release is 1.3.1

 - Not needed: rm -rf $RPM_BUILD_ROOT

 - %setup -n %{name}-%{commit}
%patch0 -p1
%patch1 -p1

   Just use:

%autosetup -p1 -n %{name}-%{commit}

 - Add a comment above each patch explaining why they are needed.

 - The %license LICENSE is not needed here as this subpackage depends already
on the main one which includes the license.

%files -n %{name}-devel
%license LICENSE

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/DHAG4HRUFYLBXYXGRHVGK4H4RDE2OOOS/




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux