https://bugzilla.redhat.com/show_bug.cgi?id=1614549 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx Depends On| |1614550 --- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - Why do you package a snapshot instead of the latest release? - If you do package a snapshot, then the Release field must contain info about it, see https://fedoraproject.org/wiki/Packaging:Versioning#Snapshots %global commit a7e4d911e92a7063888528afe0efe321c02b9a7b %global shortcommit %(c=%{commit}; echo ${c:0:7}) %global snapshotdate 20180807 Name: CubicSDR Version: 0.2.4 Release: 1.%{snapshotdate}git%{shortcommit}%{?dist} - rm -rf $RPM_BUILD_ROOT is not needed - Add: Provides: bundled(lodepng) = 20180809 too Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1614550 [Bug 1614550] Review Request: liquid-dsp - Digital signal processing library for software-defined radios -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/FULKVCHE7ABSPRU5LHS57QT6P2ORBVPH/
