Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: serenity - KDE Style and Window Decoration https://bugzilla.redhat.com/show_bug.cgi?id=284961 cgoorah@xxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |cgoorah@xxxxxxxxxxxx Status|NEW |ASSIGNED ------- Additional Comments From cgoorah@xxxxxxxxxxxx 2007-09-12 17:28 EST ------- (In reply to comment #0) > This is my second package, and I am looking for a sponsor. If it is your second package, how did you submit your first package ? what is the name of your first package? I can sponsor you but first I would like to see whether you have understood the fedora packaging guidelines. So please do at least 2 informal reviews of any package of your choice by adding me as CC: to that bug. #001: As for your %docs, copy/rename docs, so we don't need subdirs in docdir, I'm ok with it. #002: BuildRequires: kdebase-devel >= 3.0 Remove >= 3.0, as fedora core 6 and onwards already has a kde beyond 3.0 #003: # FIXME: ldconfig needed? no it doesn't. use rpmlint to verify. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review