[Bug 1576792] Review Request: python3-webthing - HTTP Web Thing implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1576792



--- Comment #7 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
(In reply to Peter Robinson from comment #3)
> (In reply to Robert-André Mauchin from comment #2)
> >  - Use a more meaningful archive name with:
> > 
> > Source0:       
> > https://github.com/mozilla-iot/webthing-python/archive/v%{version}/%{name}-
> > %{version}.tar.gz
> 
> When I packaged this they weren't there, it was from my request they
> happened:
> https://github.com/mozilla-iot/webthing-python/issues/13
> 
You misunderstood me maybe, my advice is to change the Source0 to have an
archive name with both name and version instead of only the version:


Source0:       
https://github.com/mozilla-iot/webthing-python/archive/v%{version}/%{name}-%{version}.tar.gz

> 
> >  - I think you should name this package python-webthing and provide a Python
> > 3 subpackage. You could use pyp2rpm to help with that: pyp2rpm -b3 webthing
> > > python-webthing.spec and then adjust the patch, license, description.
> 
> I'm considering that, although I'd use python3-webthing naming because I
> have no intention of supporting py2

The policy is still to make a subpackage even if you only make a python3
version. I asked about this a few moths back on IRC.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/ODNNGPPXE7H7ZPP7ZPFIBLEJXGOSPPPV/




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux