[Bug 1157255] Review Request: ufoai - UFO: Alien Invasion strategy game

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1157255



--- Comment #28 from Ben Rosser <rosser.bjr@xxxxxxxxx> ---
Well... I have gone through ufoai.spec and cleaned it up, modernizing and
fixing some things.

In particular I patched the configure script so that it does not fail when it
receives unrecognized options, meaning that the %configure macro can be used.

I then had to do some work to get the package to build at all; the biggest
thing that worries me is that I had to add -Wno-narrowing to CFLAGS to get
things to compile, which maybe isn't okay.

I have yet to take a detailed look at the ufoai-data package, but I am assuming
the issue with unbundling things is that all the data files are compressed into
.pk3 archives, so the pk3s would need to be extracted, content unbundled, and
then re-packed.

I am not sure if this is worth it, honestly, especially given the more lenient
bundling guidelines of the present day. Since we know that horai-ume-fonts has
been approved by Fedora Legal, I don't know if there's really a problem with
keeping it in this package anymore. I don't particularly feel motivated to do
it, anyway.

But I will post the updated specs somewhere.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/2IBT74RB5JY5SGSRYM5ZHUO5REYJMDAL/




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux