[Bug 1601186] Review Request: wpewebkit - A WebKit port optimized for low-end devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1601186



--- Comment #34 from Michael Catanzaro <mcatanzaro@xxxxxxxxx> ---
No clue.

Maybe it's time to figure out why you needed to specify -lrt in
CMAKE_EXE_LINKER_FLAGS, since of course that should not be necessary.

I see the error you're getting for ARM is:

/usr/bin/ld:
CMakeFiles/WebKit.dir/__/__/DerivedSources/WebKit/unified-sources/UnifiedSource10.cpp.o:
in function `WebKit::SharedMemory::create(void*, unsigned long,
WebKit::SharedMemory::Protection)':
/builddir/build/BUILD/wpewebkit-2.21.2/Source/WebKit/Platform/unix/SharedMemoryUnix.cpp:119:
undefined reference to `shm_open'
/usr/bin/ld:
/builddir/build/BUILD/wpewebkit-2.21.2/Source/WebKit/Platform/unix/SharedMemoryUnix.cpp:142:
undefined reference to `shm_unlink'
/usr/bin/ld:
/builddir/build/BUILD/wpewebkit-2.21.2/Source/WebKit/Platform/unix/SharedMemoryUnix.cpp:138:
undefined reference to `shm_unlink'
collect2: error: ld returned 1 exit status

And shm_open(3) does say clearly: "Link with -lrt."

I see in Source/WebKit/CMakeLists.txt:

if (UNIX)
    check_function_exists(shm_open SHM_OPEN_EXISTS)
    if (NOT SHM_OPEN_EXISTS)
        set(CMAKE_REQUIRED_LIBRARIES rt)
        check_function_exists(shm_open SHM_OPEN_REQUIRES_LIBRT)
        if (SHM_OPEN_REQUIRES_LIBRT)
            list(APPEND WebKit_LIBRARIES PRIVATE rt)
        endif ()
        unset(CMAKE_REQUIRED_LIBRARIES)
    endif ()
endif ()

And in the aarch64 build log:

-- Looking for shm_open
-- Looking for shm_open - found

If -lrt were required for shm_open, I would have expected it to have printed:

-- Looking for shm_open
-- Looking for shm_open - not found
-- Looking for shm_open
-- Looking for shm_open - found

That output is the same on x86_64, as well.

So something seems to be going wrong there, which I don't understand. That
problem creates the need for you to manually pass -lrt. And then something
additional is going wrong on ARM for the -lrt to get lost....

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/N3JMSWGLOMYOK2GIBX36M74MWEY3LRHM/




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux