https://bugzilla.redhat.com/show_bug.cgi?id=1610554 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zbyszek@xxxxxxxxx --- Comment #4 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- So... if I read the script to build .pms, /usr/share/doc/hsxkpasswd/xscripts/generateDictionaries.pl correctly, it converts sample_dict_DE.txt into DE.pm and so on, for each language. So the "sample_dict_*.txt" files should be considered sources. Then they are packaged twice: $ rpm -ql hsxkpasswd-3.6-1.fc27.noarch|grep sample /usr/share/doc/hsxkpasswd/share/sample_config.json /usr/share/doc/hsxkpasswd/share/sample_dict_DE.txt /usr/share/doc/hsxkpasswd/share/sample_dict_EN.txt /usr/share/doc/hsxkpasswd/share/sample_dict_ES.txt /usr/share/doc/hsxkpasswd/share/sample_dict_FR.txt /usr/share/doc/hsxkpasswd/share/sample_dict_IT.txt /usr/share/doc/hsxkpasswd/share/sample_dict_NL.txt /usr/share/doc/hsxkpasswd/share/sample_dict_PT.txt /usr/share/doc/hsxkpasswd/share/sample_hsxkpasswdrc /usr/share/perl5/vendor_perl/auto/share/dist/Crypt-HSXKPasswd/sample_config.json /usr/share/perl5/vendor_perl/auto/share/dist/Crypt-HSXKPasswd/sample_dict_DE.txt /usr/share/perl5/vendor_perl/auto/share/dist/Crypt-HSXKPasswd/sample_dict_EN.txt /usr/share/perl5/vendor_perl/auto/share/dist/Crypt-HSXKPasswd/sample_dict_ES.txt /usr/share/perl5/vendor_perl/auto/share/dist/Crypt-HSXKPasswd/sample_dict_FR.txt /usr/share/perl5/vendor_perl/auto/share/dist/Crypt-HSXKPasswd/sample_dict_IT.txt /usr/share/perl5/vendor_perl/auto/share/dist/Crypt-HSXKPasswd/sample_dict_NL.txt /usr/share/perl5/vendor_perl/auto/share/dist/Crypt-HSXKPasswd/sample_dict_PT.txt /usr/share/perl5/vendor_perl/auto/share/dist/Crypt-HSXKPasswd/sample_hsxkpasswdrc I don't think those files are useful for anything, just drop them from the binary package. Similarly, the script could be considered a build script and dropped from documentation too. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/6I44DYCIDXDTDTIZNLS6N3W7VZNUQJJP/
