https://bugzilla.redhat.com/show_bug.cgi?id=1611829 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #5 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- Stefan is also the maintainer of libtpms, I assume he will update it too. - Group: is not needed in Fedora - BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root is not used anymore - Don't use %define, use %global - Use %bcond_with/%bcond_without instead of %define with_gnutls 1 - %defattr(-,root,root,-) %attr( 755, root, root) Not necessary as it is the default, only use defattr when you're changing the default value - %{_libdir}/libswtpm_libtpms.so.* New guidelines: don't use a glob for major soname version to avoid accidental soname bump. See the new guidelines here https://pagure.io/packaging-committee/issue/784 - make %{?_smp_mflags} → %make_build - make %{?_smp_mflags} install DESTDIR=${RPM_BUILD_ROOT} → %make_install - rm -f ${RPM_BUILD_ROOT}%{_libdir}/*.a ${RPM_BUILD_ROOT}%{_libdir}/*.la → rm -rf $RPM_BUILD_ROOT%{_libdir}/*.{a,la} - Not needed anymore, this is handled by %transfiletrigger now for F28+. If you plan to package for F27/EPEL use %ldconfig_scriptlets instead: %post libs -p /sbin/ldconfig %postun libs -p /sbin/ldconfig - add a %changelog %entry - Use %selinux_modules_install/%selinux_modules_uninstall/%selinux_relabel_post See https://fedoraproject.org/wiki/SELinux/IndependentPolicy#The_.25post_Section -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/NG5ZRQJ7N7AHOPNCD5XMHFB3F2VH6OWC/
