https://bugzilla.redhat.com/show_bug.cgi?id=1611828 --- Comment #5 from Georg Sauthoff <fedora@xxxxxxxx> --- Yes, it makes sense to suggest/recommend the optional packages. I added the optional packages as weak dependencies (one recommends and the rest as suggests). Regarding EPL-1.0 - yes, it's a false positive because the rpmlint config includes this comment: # These are the short names for all of the Fedora approved licenses. # The master list is kept here: http://fedoraproject.org/wiki/Licensing # Last synced with revision "2.36, 18 April 2017" of that page. (https://src.fedoraproject.org/rpms/rpmlint/blob/master/f/rpmlint.config#_43-45 or /usr/share/rpmlint/config) Also, the config even lists 'EPL' (without version qualifier): https://src.fedoraproject.org/rpms/rpmlint/blob/master/f/rpmlint.config#_114 I'll try to submit a pull-request that adds the version qualified EPL tags to the rpmlint package. I added a sed call that fixes the shebang lines. The spec file now uses the srcname macro in more places. AFAICS, the main advantage of the py3_dist macro is that I don't have to change a dependency name (in requires/buildrequires) when the fedora name of such a dependency changes - because the standardized name (usually) doesn't change. Since I don't see this as a big advantage for this package right now, I haven't transformed the requires/buildrequires to py3_dist macro calls. Updated SPEC file: https://raw.githubusercontent.com/gsauthof/copr-fedora/196fafef5f720f7322ae4b44e599d09eadedc83d/python-asyncssh/python-asyncssh.spec New SRPM: https://copr-be.cloud.fedoraproject.org/results/gsauthof/fedora/fedora-rawhide-x86_64/00784369-python-asyncssh/python-asyncssh-1.13.3-1.fc29.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/P6TKSIELKLV4WMCGCVLDPYS65NPZQ4SL/
