https://bugzilla.redhat.com/show_bug.cgi?id=1611828 --- Comment #3 from Iñaki Ucar <i.ucar86@xxxxxxxxx> --- This is an informal review. Some comments: - Shouldn't be the optional packages suggested? - EPL-1.0 is reported as an invalid license by rpmlint, but I'm not sure whether this could be a false positive, because it is listed here: https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Good_Licenses - Note that all the examples have "/usr/bin/env" in the shebang line. This must be fixed. https://fedoraproject.org/wiki/Packaging:Guidelines#Shebang_lines -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/3DFC6ZHKNF77C5FSBON3FSFWEVDDGV6B/
