https://bugzilla.redhat.com/show_bug.cgi?id=1612092 Iñaki Ucar <i.ucar86@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |i.ucar86@xxxxxxxxx --- Comment #1 from Iñaki Ucar <i.ucar86@xxxxxxxxx> --- This is an informal review. Some comments: - Source -> you can use %pypi_source https://fedoraproject.org/wiki/Packaging:Python#Source_Files_from_PyPI - Why does build require git? - A brief comment on what the patches do, apart from the reference URLs, is advisable - You can use %{py3_dist} to resolve to standardized names https://fedoraproject.org/wiki/Packaging:Python#Requires_and_BuildRequires_with_standardized_names - You can use %{?systemd_requires} as a shortcut for listing the per-scriptlet dependencies on systemd https://fedoraproject.org/wiki/Packaging:Scriptlets#Systemd - There is a %{_unitdir} macro for systemd service files https://fedoraproject.org/wiki/Packaging:Systemd#Filesystem_locations - %setup, %patch -> %autosetup applies patches automatically https://fedoraproject.org/wiki/Packaging:Guidelines#Applying_patches - %{__python3} setup.py build -> %py3_build, %{__python3} setup.py install -> %py3_install https://fedoraproject.org/wiki/Packaging:Python#Macros - Not needed: rm -rf %{buildroot} https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections - rm -rf src/%{pypi_name}.egg-info -> the egg-info is not binary and must be included https://fedoraproject.org/wiki/Packaging:Python#Files_to_include - Packages with cron job files must have an explicit Requires: crontabs https://fedoraproject.org/wiki/Packaging:CronFiles -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/4NOUQXWLD6FO4YEZKCYXGQZZ6IA2OWG5/
