[Bug 1610925] Re-Review Request: rubygem-factory_bot - Framework and DSL for defining and using model instance factories

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1610925



--- Comment #5 from Pavel Valena <pvalena@xxxxxxxxxx> ---
(In reply to Jaroslav Prokop from comment #4)
> I reviewed the package and found no offense. But for clarity I would
> appreciate srpm and raw spec urls which will be uploaded.

They're available in the description/comments, but I can reiterate:

SRPM:
https://kojipkgs.fedoraproject.org//work/tasks/7272/28767272/rubygem-factory_bot-4.10.0-1.fc29.src.rpm
Spec:
https://src.fedoraproject.org/fork/pvalena/rpms/rubygem-factory_girl/raw/rebase/f/rubygem-factory_bot.spec


> rpmlint out:
> ~~~
> rubygem-factory_bot.spec: W: invalid-url Source2:
> factory_bot-4.10.0-features.tar.gz
> rubygem-factory_bot.spec: W: invalid-url Source1:
> factory_bot-4.10.0-specs.tar.gz
> rubygem-factory_bot.noarch: W: obsolete-not-provided rubygem-factory_girl
> rubygem-factory_bot.noarch: W: no-documentation
> rubygem-factory_bot.src: W: invalid-url Source2:
> factory_bot-4.10.0-features.tar.gz
> rubygem-factory_bot.src: W: invalid-url Source1:
> factory_bot-4.10.0-specs.tar.gz
> 3 packages and 1 specfiles checked; 0 errors, 6 warnings.
> ~~~

Regarding the sources- it's a false positive.
Please check the comments in .spec file. The procedure used to create the file
is there (you can also 'unpack' it from srpm to check the content itself).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/OKTJ2FLT7CXIL5SL6RKY2F37LWM6XAJ3/




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux