https://bugzilla.redhat.com/show_bug.cgi?id=1494915 Robert Scheck <redhat-bugzilla@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |redhat-bugzilla@linuxnetz.d | |e --- Comment #7 from Robert Scheck <redhat-bugzilla@xxxxxxxxxxxx> --- The %post section IMHO looks very dubious, my thoughts and suggestions: - http://rpm.org/wiki/Releases/4.7.0#POSIX.1edraft15filecapabilities says there is %caps() meanwhile, thus no need for direct setcap calls, I would guess. - Why is %{_localstatedir}/cache/loolwsd created and owned rather using %attr(750, lool, lool) %{_localstatedir}/cache/loolwsd in %files? - Why is %{_localstatedir}/cache/loolwsd/* removed in %post? That maybe should be documented inside of the spec file...if really needed. - Why does loolwsd need a directory on the same filesystem like LibreOffice? And shouldn't something like this (if really needed) either go to a systemd unit file as ExecStartPre or just get part of %files? There is no documented reason why it has to be on the same filesystem...or? Could you add bugzilla "depends on" for the missing nodejs dependencies (if there are meanwhile individual review requests) so that somebody can easily see which dependencies are missing? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/7VRB5B7BW2DRZI5W2HQIIPW56YM6U7JO/
