https://bugzilla.redhat.com/show_bug.cgi?id=1580121 Iñaki Ucar <i.ucar86@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |i.ucar86@xxxxxxxxx --- Comment #10 from Iñaki Ucar <i.ucar86@xxxxxxxxx> --- Please, note that this is an informal review, and I'm not familiar with the Meson build system. > https://raw.githubusercontent.com/systemd/systemd-netlogd/master/systemd-netlogd.spec Please, also provide the srpm file. A koji build would be helpful too. > Summary: Forwards messages from the journal to other hosts over the network using syslog format RFC 5424 The summary is too long. I would consider a shorter one if possible. > License: GPLv2 and LGPL-2.1+ and CC0 It should be "GPLv2 and LGPLv2+ and CC0". The ".1" should not be specified. And the license breakdown should be included in the spec as comments (i.e., which files correspond to which license). Also, license files should be included using the %license macro. > Getting https://github.com/systemd/systemd-netlogd/archive/v1.1.* to ./v1.1.* > Did you tested. It did not worked with me. If you can you give me a working example The URL is ok. Artur was referring to the *man* page. The line %{_mandir}/man1/systemd-netlogd.1.gz should be instead %{_mandir}/man1/systemd-netlogd.1* Note also that you can use %{name} to replace every appearance of "systemd-netlogd" (except for the first one, of course). > %{_sysconfdir}/systemd/system/systemd-netlogd.conf These directories (%{_sysconfdir}/systemd, %{_sysconfdir}/systemd/system, etc.) are not owned by your package, because they are owned by systemd, but you didn't include systemd as a requirement. You should use the macro %{?systemd_requires} to solve this. For more information about systemd macros that you may need, see https://fedoraproject.org/wiki/Packaging:Scriptlets#Systemd > * Mon May 21 2018 Susant Sahani <susant@xxxxxxxxxx> - 1.1 Note that the version number in the changelog should include the Fedora release number, i.e., 1.1-1. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/QXTDBF7QJBNHLRQSK7BI24RZN6ISDH4R/
