https://bugzilla.redhat.com/show_bug.cgi?id=1609038 --- Comment #4 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- (In reply to ralford from comment #3) > > - Use a more meaningful name for your archive: > > > > Source0: https://%{provider_prefix}/archive/v%{version}/%{name}-% {version}.tar.gz > > That results in the source url no longer being valid and doesn't that go > against the Fedora url guidelines which wants the actual source url? > The source URL I provided is valid, check again. > > - Add a comment above the patch describing why it is needed. > > Will fix > > > - You should unbundle the dependencies and remove the vendor directory in %prep (might take a while). That implies packaging any missing dependency. > > This was recommended to me by one of the package wranglers as well as the > cri-o people until the GO packaging guidelines are finalized > Could take months, packages are already being unbundled. > > - It is not ok to apply a patch on some architecture only. The arch detection if needed should be in the patched code itself. > > Will fix > > > - with_bundled isn't defined anywhere. > > Will fix > > > There's a new way to package the Go libraries, see https://fedoraproject.org/wiki/More_Go_packaging and samples: https://eclipseo.fedorapeople.org/golang/ > > > > It would be great to convert to the new style for F27-Rawhide and keep the old style for EPEL7. > > That looks to be a proposal. Does the draft not have precedence? Most Go packages have already been converted to the new style this past year. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/YAYAM7OVJBDIQX2YJY4MUUTKRT7353PY/
