https://bugzilla.redhat.com/show_bug.cgi?id=1273579 --- Comment #23 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- So luckily there's no conflict over /usr/bin/nest. Nestopia uses /usr/bin/nestopia and nested uses /usr/bin/nested. Similarly for /usr/bin/sli, there are a few similar names, but nothing exactly the same. + package name is correct + license is acceptable for Fedora (GPLv2+) + license is specified correctly + builds and installs OK + Provides/Requires/BuildRequires appear to be correct Please change "Cython" to "python2-Cython" + latest version %define is used, either replace by %global or add an explanatory comment. > %global do_make_build \ > pushd %{name}-simulator-%{version}$MPI_COMPILE_TYPE && \ > make %{?_smp_mflags} \ > popd; This can be written as simply > make %{?_smp_mflags} -C %{name}-simulator-%{version}$MPI_COMPILE_TYPE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/WI4GSWW6E7ADJOOCT4B5F2ANZHVU32RN/
