https://bugzilla.redhat.com/show_bug.cgi?id=1592254 --- Comment #3 from Anderson Sasaki <ansasaki@xxxxxxxxxx> --- (In reply to Anderson Sasaki from comment #2) > > Some issues that are worth considering: > > 1) This package conflicts with slurm-gui package. (/usr/bin/smap) > > Ouch! I was not aware of this package. I will find a solution soon (probably > renaming the executable) The upstream was changed to generate 2 copy binaries in the new 0.2.5 release: smap and symver-smap. smap is now deleted in the install process, leaving only symver-smap ins /usr/bin/ > > 2) %{python3_sitelib}/* is not nice, you might end up owning > %{python3_sitelib}/__pycache__ for example. Since you do not install any > top-level cache, this is not the case, but you never know what future > versions will bring. You could do something like %{python3_sitelib}/smap/*, > which is more acceptable. > > Agreed. I missed that on the Fedora Python Packaging Guidelines, more > specifically https://fedoraproject.org/wiki/Packaging:Python#Byte_compiling. > It says explicitly that you should not do that. I'll fix it. Fixed this to include only the content of the smap subdirectory and the egg-info directory. > > 3) %check, perhaps you could package the test dependency first or skip the > failing part of tests? (this will probably will not be required to accept > the package, but it would be nice to have working tests) > > Agreed. I am working with the upstream developer to package the test > dependency. So this will probably be blocked until I finish packaging it. Since the pytest-console-scripts upstream developer is taking too long to change its testing, I've added a patch to disable the tests depending on pytest-console-scripts. The rest of the test suite is run on %check. When pytest-console-scripts is available in Fedora, this patch can be dropped. Summary of changes: * Changed version to symver-smap-0.2.5 * Disabled tests depending on pytest-console-scripts by a downstream patch * Included only %{python3_sitelib}/smap and %{python3_sitelib}/symver_smap-%{version}-py%{python3_version}.egg-info * Fixed PYTHONPATH when generating documentation with sphinx (previously the generated documentation were incomplete) New URLs: Spec URL: https://copr-be.cloud.fedoraproject.org/results/ansasaki/python-symver-smap/fedora-rawhide-x86_64/00781057-python-symver-smap/python-symver-smap.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/ansasaki/python-symver-smap/fedora-rawhide-x86_64/00781057-python-symver-smap/python-symver-smap-0.2.5-1.fc29.src.rpm Copr build: https://copr.fedorainfracloud.org/coprs/ansasaki/python-symver-smap/build/781057/ Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=28618195 Fedora Account System Username: ansasaki -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/I6RRCXQ4OXF4SWQTK4CB7HQTXNAY6HIH/
