https://bugzilla.redhat.com/show_bug.cgi?id=1273579 --- Comment #22 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- > # They run their tests per commit, so we don't need to run them here to check > # it all again. That's almost certainly wrong. Upstream does not test the same combination of architectures, system libraries, compiler, compilation flags, and local patches that we do. Testing at build time is not *required*, but is usually a good idea. > BuildRequires: ncurses-devel gsl-devel readline-devel > BuildRequires: python2-devel Cython > BuildRequires: python3-devel python3-Cython One per line please! > %global _description NEST is a simulator for spiking neural network models that \ > focuses on the dynamics, size and structure of neural systems rather than on \ You can instead do: > %global _description \ > NEST is a ... The advantage is that the first line is not shorter than the later ones. > %setup -q -n %{name}-simulator-%{version} > %patch0 -p1 > %patch1 -p1 → %autosetup -n %{name}-simulator-%{version} -p1 > - Do not make mpi packages noarch, since MPI_HOME is arch dependent---check "---check" left over. Pfff, that's a beast of a package. It's still building here, I might have some more comments after fedora-review is done. So far nothing major. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/EDR7RRREUHLXZGH2AQUZ65DB2DOJRBLZ/
