[Bug 1608401] Review Request: python-pyperclip - A cross-platform clipboard module for Python

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1608401

Pierre-YvesChibon <pingou@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
              Flags|                            |fedora-review+



--- Comment #1 from Pierre-YvesChibon <pingou@xxxxxxxxxxxx> ---
* Spec is nice and clean
  - I'd recommend using the new %pypi_source macro but that's at your option
  - I'd also recommend including the CHANGES.txt in the %doc (though looking at
the MANIFEST.in I'm not sure upstream ships it in their tarball)
  - I'd recommend asking upstream to include their LICENSE.txt file so it can
be flagged in the spec file
* Builds fine in all arches:
  https://koji.fedoraproject.org/koji/taskinfo?taskID=28595642
* License is valid and correct
* Basic test of the code shows no error:
   >>> import pyperclip
   >>> pyperclip.copy('foo')
   >>> pyperclip.paste()
   'foo'

APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/AMJAWN4VQEW63ROTVKYEVINDK2CJJDU3/




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux