https://bugzilla.redhat.com/show_bug.cgi?id=1607554 Jeremy Cline <jcline@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jcline@xxxxxxxxxx --- Comment #1 from Jeremy Cline <jcline@xxxxxxxxxx> --- A few small issues: * Two "# define buildid .local" comment lines at the top of the spec * The comment about "We used to have some extra magic weirdness to bump this automatically" is probably no longer relevant and could be trimmed (although it doesn't really hurt anything, either). * The "defattr" in the files section is not necessary[0] as those are the default values, I believe. * The %{_prefix} (/usr) and %{_includedir} (%{_prefix}/include) macros could be used. Otherwise it looks good to me. I'll give other people a chance to review it, though. [0] https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/F6ZQ4JDNRAD5GCV3WDAFFWSYWJNJZ7OC/
