https://bugzilla.redhat.com/show_bug.cgi?id=1607271 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - Source0 is 404. Source0 should be: Source0: https://cpan.metacpan.org/authors/id/P/PE/PETDANCE/HTML-Tidy5-%{version}.tar.gz - NO_PACKLIST=1 is only supported on perl(ExtUtils::MakeMaker) >= 6.76, thus you should constrain your BR: BuildRequires: perl(ExtUtils::MakeMaker) >= 6.76 - PERL_INSTALL_ROOT is not used anymore, it is replaced by DESTDIR: %{__make} pure_install DESTDIR=$RPM_BUILD_ROOT - You need add perl-interpreter at a BR: perl-interpreter – The Perl interpreter must be listed as a build dependency if it is called in any way, either explicitly via perl or %__perl, or as part of your package's build system. BuildRequires: perl-interpreter URL and Source addresses are Ok. Source archive (SHA-256: c9fd157e4026df7b4550d2ab51934e83d96640c721ffa8869758971b3276effe) is original. Ok. Summary verified from lib/HTML/Tidy5.pm. Ok. Description verified from lib/HTML/Tidy5.pm. Ok. License verified from lib/HTML/Tidy5.pm and README.md. Ok. XS code, BuildArch is arched: Ok. All tests pass. Ok. $ rpmlint perl-HTML-Tidy5.spec review-perl-HTML-Tidy5/results/perl-HTML-Tidy5-1.04-1.fc29.x86_64.rpm review-perl-HTML-Tidy5/results/perl-HTML-Tidy5-1.04-1.fc29.src.rpm perl-HTML-Tidy5.x86_64: W: no-manual-page-for-binary webtidy5 2 packages and 1 specfiles checked; 0 errors, 1 warnings. $ rpm -q -lv -p perl-HTML-Tidy5-1.04-1.fc29.x86_64.rpm -rwxr-xr-x 1 root root 2089 juil. 23 19:38 /usr/bin/webtidy5 drwxr-xr-x 2 root root 0 juil. 23 19:38 /usr/lib/.build-id drwxr-xr-x 2 root root 0 juil. 23 19:38 /usr/lib/.build-id/e3 lrwxrwxrwx 1 root root 64 juil. 23 19:38 /usr/lib/.build-id/e3/78e0ea2bf87d25ce06b5b87362873585767884 -> ../../../../usr/lib64/perl5/vendor_perl/auto/HTML/Tidy5/Tidy5.so drwxr-xr-x 2 root root 0 juil. 23 19:38 /usr/lib64/perl5/vendor_perl/HTML drwxr-xr-x 2 root root 0 juil. 23 19:38 /usr/lib64/perl5/vendor_perl/HTML/Tidy5 -rw-r--r-- 1 root root 10957 avril 20 23:49 /usr/lib64/perl5/vendor_perl/HTML/Tidy5.pm -rw-r--r-- 1 root root 2489 avril 4 21:41 /usr/lib64/perl5/vendor_perl/HTML/Tidy5/Message.pm drwxr-xr-x 2 root root 0 juil. 23 19:38 /usr/lib64/perl5/vendor_perl/Test drwxr-xr-x 2 root root 0 juil. 23 19:38 /usr/lib64/perl5/vendor_perl/Test/HTML -rw-r--r-- 1 root root 4095 avril 20 23:49 /usr/lib64/perl5/vendor_perl/Test/HTML/Tidy5.pm drwxr-xr-x 2 root root 0 juil. 23 19:38 /usr/lib64/perl5/vendor_perl/auto/HTML drwxr-xr-x 2 root root 0 juil. 23 19:38 /usr/lib64/perl5/vendor_perl/auto/HTML/Tidy5 -rwxr-xr-x 1 root root 19776 juil. 23 19:38 /usr/lib64/perl5/vendor_perl/auto/HTML/Tidy5/Tidy5.so drwxr-xr-x 2 root root 0 juil. 23 19:38 /usr/share/doc/perl-HTML-Tidy5 -rw-r--r-- 1 root root 1164 avril 20 23:49 /usr/share/doc/perl-HTML-Tidy5/Changes -rw-r--r-- 1 root root 901 mars 26 23:32 /usr/share/doc/perl-HTML-Tidy5/README.md -rw-r--r-- 1 root root 3607 juil. 23 19:38 /usr/share/man/man3/HTML::Tidy5.3pm.gz -rw-r--r-- 1 root root 1754 juil. 23 19:38 /usr/share/man/man3/HTML::Tidy5::Message.3pm.gz -rw-r--r-- 1 root root 2196 juil. 23 19:38 /usr/share/man/man3/Test::HTML::Tidy5.3pm.gz File permissions and layout are Ok. $ rpm -q --requires -p perl-HTML-Tidy5-1.04-1.fc29.x86_64.rpm | sort -f | uniq -c 1 /usr/bin/perl 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 libperl.so.5.28()(64bit) 1 libpthread.so.0()(64bit) 1 libpthread.so.0(GLIBC_2.2.5)(64bit) 1 libtidy.so.5()(64bit) 1 perl(:VERSION) >= 5.10.1 1 perl(base) 1 perl(Carp) 1 perl(constant) 1 perl(Exporter) 1 perl(Getopt::Long) 1 perl(HTML::Tidy5) 1 perl(HTML::Tidy5::Message) 1 perl(parent) 1 perl(strict) 1 perl(Test::Builder) 1 perl(warnings) 1 perl(XSLoader) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 rtld(GNU_HASH) Binary requires are Ok. $ rpm -q --provides -p perl-HTML-Tidy5-1.04-1.fc29.x86_64.rpm perl(HTML::Tidy5) = 1.04 perl(HTML::Tidy5::Message) perl(Test::HTML::Tidy5) = 1.04 perl-HTML-Tidy5 = 1.04-1.fc29 perl-HTML-Tidy5(x86-64) = 1.04-1.fc29 Binary provides are Ok. Package does not build in F29 (https://koji.fedoraproject.org/koji/taskinfo?taskID=28545894) Tests failure on i686. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/WUMP5WT23WV5XYFIVDB75BQCTH6DWS5T/
