https://bugzilla.redhat.com/show_bug.cgi?id=1607124 --- Comment #3 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- I can't build it so I can't continue the review without the patch. I'll patch it myself then. Tests failures: failures: ---- build_auth::http_auth_offered stdout ---- running `/builddir/build/BUILD/cargo-0.28.0/target/release/cargo build -v` running `/builddir/build/BUILD/cargo-0.28.0/target/release/cargo build` thread 'build_auth::http_auth_offered' panicked at 'called `Option::unwrap()` on a `None` value', libcore/option.rs:335:21 ---- build_script::custom_build_env_var_rustc_linker stdout ---- thread 'build_script::custom_build_env_var_rustc_linker' panicked at 'Cannot cross compile to i686-unknown-linux-gnu. This failure can be safely ignored. If you would prefer to not see this failure, you can set the environment variable CFG_DISABLE_CROSS_TESTS to "1". ', tests/testsuite/cargotest/support/cross_compile.rs:91:5 ---- new::author_prefers_cargo stdout ---- thread 'new::author_prefers_cargo' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" } could not execute process `git config --global user.name foo` (never executed)', libcore/result.rs:945:5 ---- new::finds_author_git stdout ---- thread 'new::finds_author_git' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" } could not execute process `git config --global user.name bar` (never executed)', libcore/result.rs:945:5 ---- new::finds_local_author_git stdout ---- thread 'new::finds_local_author_git' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" } could not execute process `git init` (never executed)', libcore/result.rs:945:5 failures: build_auth::http_auth_offered build_script::custom_build_env_var_rustc_linker new::author_prefers_cargo new::finds_author_git new::finds_local_author_git test result: FAILED. 1280 passed; 5 failed; 4 ignored; 0 measured; 0 filtered out -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/2PU6QJ2QJKKBOEQLQKBHGG6TY2ZZDDOH/
