https://bugzilla.redhat.com/show_bug.cgi?id=1607091 --- Comment #2 from Tomáš Hozza <thozza@xxxxxxxxxx> --- Thanks for review. (In reply to Robert-André Mauchin from comment #1) > - Use a more meaningful name for your archive with: > > Source0: %url/archive/v%{version}/%{name}-%{version}.tar.gz I was not sure how to fixed this with github. I fixed this to download the archive using the name of the upstream project, not the package, to reduce confusion. > > - %setup v%{version}.tar.gz -n gnome-extension-taskwarrior-%{version} > > Use %autosetup -n gnome-extension-taskwarrior-%{version} I changed this, although %setup vs. %autosetup is a thing of maintainer preference. > > - %dir %{gnome_extensions_dir}/%{uuid} > %{gnome_extensions_dir}/%{uuid}/* > > Simply use instead: > > %{gnome_extensions_dir}/%{uuid} This is cosmetic change. Yes, SPEC is shorter, but I take the %dir to be more explicit. Nevertheless I changed it. > - Split the description to stay below 80 characters per line: > > gnome-shell-extension-taskwarrior.noarch: E: description-line-too-long C > This GNOME shell extension is enabling access to Taskwarrior from the gnome > shell taskbar. Done. I updated SPEC, SRPM and COPR: Spec URL: https://thozza.fedorapeople.org/gnome-shell-extension-taskwarrior/gnome-shell-extension-taskwarrior.spec SRPM URL: https://thozza.fedorapeople.org/gnome-shell-extension-taskwarrior/gnome-shell-extension-taskwarrior-4.0-2.fc28.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/67IWM7AXN6X3AORA36TU6RIADX2WZOMY/
