https://bugzilla.redhat.com/show_bug.cgi?id=1602059 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- Version: 03032018 Release: 2.0.g570fa5%{?dist} - That's not a correct version/release, don't use the date but the version provided on Github: Version: 3.3 Release: 2%{?dist} - Add a comment above each patch explaining why they are needed or ling to an upstream bug: Patch0: pic_flag.patch Patch1: pkgconfig_include.patch - Capitalize the summary and description - make %{?_smp_mflags} → %make_build - ldconfig is not needed anymore starting Fedona 28: %post -n libsafec -p /sbin/ldconfig %postun -n libsafec -p /sbin/ldconfig See https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets - Not needed: %defattr(-,root,root) It is already the default. - Not needed: %{_includedir}/libsafec/safe_compile.h %{_includedir}/libsafec/safe_config.h %{_includedir}/libsafec/safe_lib_errno.h %{_includedir}/libsafec/safe_lib.h %{_includedir}/libsafec/safe_mem_lib.h %{_includedir}/libsafec/safe_str_lib.h %{_includedir}/libsafec/safe_types.h You already included these files by specifying %{_includedir}/libsafec - Remove %define _unpackaged_files_terminate_build 0 - Thus you have an unpackaged .la file that you need to remove in %install: find %{buildroot} -name '*.la' -delete -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/BOOT4LKKES6KQZUKGKSHP35X2UUBAT6C/
