https://bugzilla.redhat.com/show_bug.cgi?id=1601186 --- Comment #5 from Chris King <bunnyapoc@xxxxxxxxx> --- (In reply to Michael Catanzaro from comment #4) > (In reply to Chris King from comment #3) > > That is something I've been wondering about, the minibrowser isn't even in > > the install files, despite my building with the cmake flage of > > ENABLE_MINIBROWSER=ON. I don't know as much about the inner workings of > > webkit/WPE as you probably do, so help on this would be great. > > Hmm, the MiniBrowser was added after 2.20, so you'll have to package a newer > tarball. 2.20 is the latest stable version (appropriate for F28), but you > probably want the latest unstable for rawhide, which will have MiniBrowser. Okay, I have a build running for that now in a different copr repo. Hopefully the same spec works for that as well: https://copr.fedorainfracloud.org/coprs/bunnyapocalypse/wpewebkit-rawhide/build/778315/ > > I have packaged wpebackend-fdo 0.1 in my copr repository, I can also make a > > package review request for that if you think that'll be necessary. > > It's definitely necessary, or it won't be able to run at all. Okay, I have made a package review request for that: https://bugzilla.redhat.com/show_bug.cgi?id=1602078 > > Trying to build without this fails in copr, so I guess it's not just my > > machine, what is the process for adding a FIXME? > > Just add a comment in the spec file. Done. The python patch was indeed necessary, both 28 and rawhide are building properly for 2.20.1 at least. Will update on 2.21.2 when that's done. New spec: https://copr-dist-git.fedorainfracloud.org/cgit/bunnyapocalypse/wpewebkit-rawhide/wpewebkit.git/tree/wpewebkit-rawhide.spec?id=f42b42524c6894b95bc5607c5c3da7bf0ced08e0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/C6KLWP2K6FDK7LU4ITDLH53DWHGGMZ25/
